Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Metrics documentation #4829

Merged
merged 8 commits into from Jan 5, 2021
Merged

fix: Metrics documentation #4829

merged 8 commits into from Jan 5, 2021

Conversation

saranyaeu2987
Copy link
Contributor

Checklist:

@saranyaeu2987 saranyaeu2987 changed the title Doc update [issue: 1682] fix: doc #1682 Jan 4, 2021
@saranyaeu2987 saranyaeu2987 changed the title fix: doc #1682 fix: metrics documentation Jan 4, 2021
@saranyaeu2987 saranyaeu2987 changed the title fix: metrics documentation fix: Metrics documentation Jan 4, 2021
@saranyaeu2987 saranyaeu2987 mentioned this pull request Jan 5, 2021
Closed
simster7
simster7 suggested changes Jan 5, 2021
View reviewed changes
docs/metrics.md Outdated Show resolved Hide resolved
@simster7
Copy link
Member

simster7 commented Jan 5, 2021

Thanks for this PR! You need to sign your commits. Please see: https://github.com/argoproj/argo/pull/4829/checks?check_run_id=1650422948

@simster7 simster7 self-assigned this Jan 5, 2021
alexec and others added 7 commits January 5, 2021 09:15
@alexec @saranyaeu2987
fix(controller): Various v2.12 fixes. Fixes argoproj#4798, argoproj#4801
605cbde 
, argoproj#4806 (argoproj#4808)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@sarabala1979 @saranyaeu2987
feat(controller): Adding Eventrecorder on LeaderElection
85dccd1 
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@saranyaeu2987
Doc update [issue: 1682]
f776c90 
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@taharah @saranyaeu2987
fix(crds): Inline WorkflowSteps schema to generate valid OpenAPI spec (…
cd059bc 
…argoproj#4828)

Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@saranyaeu2987
Update metrics.md
8c52fa3 
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@markterm @saranyaeu2987
chore: add missing phase option to node cli command (argoproj#4825)
0d336de 
Signed-off-by: Mark White <mark@markwhite.com>
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@saranyaeu2987 @simster7
Update docs/metrics.md
494be97 
Co-authored-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@saranyaeu2987
Copy link
Contributor Author

@simster7
Committed and signed. Some others' changes were added on rebase. Can you please review. I can rebase again if needed.

@simster7 simster7 merged commit 2243d34 into argoproj:master Jan 5, 2021
@simster7
Copy link
Member

simster7 commented Jan 5, 2021

Thanks!

@simster7 simster7 mentioned this pull request Jan 12, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees

@simster7 simster7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saranyaeu2987 @simster7 @alexec @sarabala1979 @taharah @markterm