feat: Publish images on Quay.io #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Jan 11, 2021
Comment on lines
+72
to
+78
| docker buildx build \ | ||
| --cache-from "type=local,src=/tmp/.buildx-cache" \ | ||
| --cache-to "type=local,dest=/tmp/.buildx-cache" \ | ||
| --output "type=image,push=true" \ | ||
| --platform="${PLATFORM}" \ | ||
| --target $TARGET \ | ||
| --tag quay.io/$image_name . |
There was a problem hiding this comment.
Unfortunately, we cannot simply build the image once and re-tag because docker buildx build pushes manifests to the registry as part of the process
There was a problem hiding this comment.
We do do this when possible though -- when building the windows image
alexec
approved these changes
Jan 11, 2021
simster7
added a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: