fix(executor): Do not make unneeded get pod when no sidecars
#5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Feb 22, 2021
| @@ -350,7 +350,7 @@ dist/kustomize: | |||
| dist/kustomize version | |||
|
|
|||
| # generates several installation files | |||
| manifests/install.yaml: $(CRDS) dist/kustomize | |||
| manifests/install.yaml: $(MANIFESTS) dist/kustomize | |||
There was a problem hiding this comment.
fixes make codegen not making manifests when changed
alexec
commented
Feb 22, 2021
| @@ -386,10 +386,12 @@ install: $(MANIFESTS) $(E2E_MANIFESTS) dist/kustomize | |||
| kubectl config set-context --current --namespace=$(KUBE_NAMESPACE) | |||
| @echo "installing PROFILE=$(PROFILE) VERSION=$(VERSION), E2E_EXECUTOR=$(E2E_EXECUTOR)" | |||
| dist/kustomize build --load_restrictor=none test/e2e/manifests/$(PROFILE) | sed 's/argoproj\//$(IMAGE_NAMESPACE)\//' | sed 's/:latest/:$(VERSION)/' | sed 's/containerRuntimeExecutor: docker/containerRuntimeExecutor: $(E2E_EXECUTOR)/' | kubectl -n $(KUBE_NAMESPACE) apply --prune -l app.kubernetes.io/part-of=argo -f - | |||
| ifeq ($(PROFILE),stress) | |||
There was a problem hiding this comment.
we don't need these unless we're running stress and this makes make start faster and more robust
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Feb 22, 2021
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| set -eu -o pipefail | |||
|
|
|||
| kubectl delete wf -l workflows.argoproj.io/test | |||
| ./dist/argo delete -l workflows.argoproj.io/test | |||
There was a problem hiding this comment.
this make make test-examples more robust
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.