-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(executor): Do not make unneeded get pod
when no sidecars
#5161
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
251664a
fix(executor): Do not make unneede `get pod` when no sidecars
alexec 8350fcd
fix(executor): Do not make unneede `get pod` when no sidecars
alexec 1740136
Merge branch 'master' into tweak
alexec c353a05
fix(executor): Do not make unneede `get pod` when no sidecars
alexec File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -350,7 +350,7 @@ dist/kustomize: | |
dist/kustomize version | ||
|
||
# generates several installation files | ||
manifests/install.yaml: $(CRDS) dist/kustomize | ||
manifests/install.yaml: $(MANIFESTS) dist/kustomize | ||
./hack/update-image-tags.sh manifests/base $(VERSION) | ||
dist/kustomize build --load_restrictor=none manifests/cluster-install | ./hack/auto-gen-msg.sh > manifests/install.yaml | ||
dist/kustomize build --load_restrictor=none manifests/namespace-install | ./hack/auto-gen-msg.sh > manifests/namespace-install.yaml | ||
|
@@ -386,10 +386,12 @@ install: $(MANIFESTS) $(E2E_MANIFESTS) dist/kustomize | |
kubectl config set-context --current --namespace=$(KUBE_NAMESPACE) | ||
@echo "installing PROFILE=$(PROFILE) VERSION=$(VERSION), E2E_EXECUTOR=$(E2E_EXECUTOR)" | ||
dist/kustomize build --load_restrictor=none test/e2e/manifests/$(PROFILE) | sed 's/argoproj\//$(IMAGE_NAMESPACE)\//' | sed 's/:latest/:$(VERSION)/' | sed 's/containerRuntimeExecutor: docker/containerRuntimeExecutor: $(E2E_EXECUTOR)/' | kubectl -n $(KUBE_NAMESPACE) apply --prune -l app.kubernetes.io/part-of=argo -f - | ||
ifeq ($(PROFILE),stress) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need these unless we're running stress and this makes |
||
kubectl -n $(KUBE_NAMESPACE) apply -f test/stress/massive-workflow.yaml | ||
kubectl -n $(KUBE_NAMESPACE) rollout restart deploy workflow-controller | ||
kubectl -n $(KUBE_NAMESPACE) rollout restart deploy argo-server | ||
kubectl -n $(KUBE_NAMESPACE) rollout restart deploy minio | ||
endif | ||
ifeq ($(RUN_MODE),kubernetes) | ||
# scale to 2 replicas so we touch upon leader election | ||
kubectl -n $(KUBE_NAMESPACE) scale deploy/workflow-controller --replicas 2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
#!/usr/bin/env bash | ||
set -eu -o pipefail | ||
|
||
kubectl delete wf -l workflows.argoproj.io/test | ||
./dist/argo delete -l workflows.argoproj.io/test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this make |
||
|
||
grep -lR 'workflows.argoproj.io/test' examples/* | while read f ; do | ||
./dist/argo submit --watch --verify $f | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes
make codegen
not making manifests when changed