Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Fix cron timezone support. Fixes #5653 #5712

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 19, 2021

No description provided.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue Apr 19, 2021 that may be closed by this pull request
@alexec alexec marked this pull request as ready for review April 19, 2021 16:58
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #5712 (d63293c) into master (0a6f2fc) will increase coverage by 0.04%.
The diff coverage is 33.33%.

❗ Current head d63293c differs from pull request most recent head d1ec292. Consider uploading reports for the commit d1ec292 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5712      +/-   ##
==========================================
+ Coverage   46.87%   46.91%   +0.04%     
==========================================
  Files         244      244              
  Lines       15216    15219       +3     
==========================================
+ Hits         7132     7140       +8     
+ Misses       7176     7171       -5     
  Partials      908      908              
Impacted Files Coverage Δ
workflow/cron/controller.go 0.75% <33.33%> (+0.75%) ⬆️
workflow/controller/operator.go 71.11% <0.00%> (+0.26%) ⬆️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6f2fc...d1ec292. Read the comment docs.

@alexec alexec merged commit 8e9e6d6 into argoproj:master Apr 19, 2021
@alexec alexec deleted the tz branch April 19, 2021 17:27
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone for CronWorkflow not working for all expected zones
3 participants