Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support RemainingItemCount in archivedWrokflow #9118

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix: support RemainingItemCount in archivedWrokflow #9118

merged 2 commits into from
Jul 19, 2022

Conversation

hadesy
Copy link
Contributor

@hadesy hadesy commented Jul 6, 2022

Signed-off-by: hadesy 6346047+hadesy@users.noreply.github.com

Fixes support RemainingItemCount in archivedWrokflow

@hadesy
fix: support RemainingItemCount in archivedWrokflow
de47185 
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
juliev0
juliev0 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@juliev0 juliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I guess the number of workflows can change between the calls to ListWorkflows() and CountWorkflows() but since metav1.ListMeta.RemainingItemCount is only supposed to be treated as an estimate, that's totally fine (as you probably rationalized).

tczhao
tczhao requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadesy Could you fix the generated code

make -B codegen

@hadesy
fix: generated code
b8b658c 
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
@hadesy
Copy link
Contributor Author

hadesy commented Jul 17, 2022

@hadesy Could you fix the generated code

make -B codegen

@tczhao Done

@sarabala1979 sarabala1979 enabled auto-merge (squash) July 19, 2022 15:10
@sarabala1979 sarabala1979 merged commit 0f1d1d9 into argoproj:master Jul 19, 2022
@sarabala1979 sarabala1979 mentioned this pull request Nov 8, 2022
Closed
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 2, 2023
@hadesy
fix: support RemainingItemCount in archivedWrokflow (argoproj#9118)
8b406a9 
* fix: support RemainingItemCount in archivedWrokflow

Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>

* fix: generated code

Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
@agilgur5 agilgur5 mentioned this pull request Jun 29, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao requested changes

@juliev0 juliev0 juliev0 approved these changes

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@juliev0 juliev0

@sarabala1979 sarabala1979

Labels
area/api Argo Server API area/workflow-archive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hadesy @juliev0 @tczhao @sarabala1979 @agilgur5