Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate toward structured logging #2308

Open
simster7 opened this issue Feb 25, 2020 · 5 comments
Open

Migrate toward structured logging #2308

simster7 opened this issue Feb 25, 2020 · 5 comments
Labels
area/controller Controller issues, panics area/server good first issue Good for newcomers hacktoberfest type/tech-debt

Comments

@simster7
Copy link
Member

Some parts of the code already have structured logging -- for example:

https://github.com/argoproj/argo/blob/214c451535ebeb6e68f1599c2c0a4a4d174ade25/persist/sqldb/workflow_archive.go#L63-L64

But most don't. Let's migrate the rest.

#2307
@simster7 simster7 added type/feature Feature request help wanted good first issue Good for newcomers labels Feb 25, 2020
@simster7 simster7 mentioned this issue Feb 25, 2020
Closed
@suzuki-shunsuke suzuki-shunsuke mentioned this issue Jul 10, 2020
Closed
6 tasks
@sh-tatsuno sh-tatsuno mentioned this issue Aug 11, 2020
Merged
5 tasks
simster7 pushed a commit that referenced this issue Aug 11, 2020
@sh-tatsuno
feat(controller): controller logs to be structured #2308 (#3727)
acfda26
@alexec
Copy link
Contributor

alexec commented Sep 2, 2020

Available for testing in v2.10.0-rc1.

@alexec alexec added type/tech-debt and removed type/feature Feature request help wanted labels Feb 7, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@alexec alexec removed the problem/stale This has not had a response in some time label Mar 2, 2022
@VUHAILAM VUHAILAM mentioned this issue Oct 9, 2022
Merged
8 tasks
@VUHAILAM
Copy link
Contributor

VUHAILAM commented Oct 9, 2022

Hope this PR: #9779 can help you. Hi @alexec and @simster7, please help me to review it

alexec pushed a commit that referenced this issue Oct 10, 2022
@VUHAILAM
feat(server): server logs to be structured and add more log error #2308…
514aa05 
… (#9779)

Signed-off-by: Lam Vu <lamvh2812@gmail.com>
Signed-off-by: Lam Vu <lvu@axon.com>
Co-authored-by: Lam Vu <lvu@axon.com>
rylim added a commit to rylim/argo-workflows that referenced this issue Oct 16, 2022
@rylim
argoproj#2308 initial commit
fde64a5
rylim added a commit to rylim/argo-workflows that referenced this issue Oct 17, 2022
@rylim
argoproj#2308 Replace log.Fatal(err) with structured version
f419669
@rylim rylim mentioned this issue Oct 17, 2022
Closed
8 tasks
@rylim
Copy link

rylim commented Oct 17, 2022 •
edited
Loading

Hi @simster7 @sarabala1979 , I submitted #9844 as a continuation of this issue fix (for hacktoberfest 🎃). I started with the log.Fatal(err) primarily to confirm that the approach is correct. Please let me know of any feedback and I can work on the remaining Fatal logs with fields, i.e. Fatalf ones.

rylim added a commit to rylim/argo-workflows that referenced this issue Oct 17, 2022
@rylim
argoproj#2308 initial commit
e8d12f7 
Signed-off-by: rylim <36293596+rylim@users.noreply.github.com>
rylim added a commit to rylim/argo-workflows that referenced this issue Oct 17, 2022
@rylim
argoproj#2308 Replace log.Fatal(err) with structured version
68a021a 
Signed-off-by: rylim <36293596+rylim@users.noreply.github.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
@VUHAILAM @juchaosong
feat(server): server logs to be structured and add more log error arg…
47828bf 
…oproj#2308 (argoproj#9779)

Signed-off-by: Lam Vu <lamvh2812@gmail.com>
Signed-off-by: Lam Vu <lvu@axon.com>
Co-authored-by: Lam Vu <lvu@axon.com>
Signed-off-by: juchao <juchao@coscene.io>
@terrytangyuan terrytangyuan mentioned this issue Aug 2, 2023
Closed
@agilgur5 agilgur5 added area/controller Controller issues, panics area/server labels Feb 10, 2024
@KyriosGN0
Copy link

Hi, is this still available to work on ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller Controller issues, panics area/server good first issue Good for newcomers hacktoberfest type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Fixes #2308 Structured Logging migration for Fatal logs rylim/argo-workflows
7 participants
@simster7 @alexec @agilgur5 @sarabala1979 @VUHAILAM @rylim @KyriosGN0