fix: build/lint is broken due to dependencies changes #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Hari <ravireliable@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 49.37% 49.37%
=======================================
Files 30 30
Lines 1760 1760
=======================================
Hits 869 869
Misses 703 703
Partials 188 188 Continue to review full report at Codecov.
|
|
Thank you! |
RaviHari
added a commit
to RaviHari/notifications-engine
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Ravi Hari <ravireliable@gmail.com>
pasha-codefresh
added a commit
that referenced
this pull request
Apr 7, 2022
* feat: PagerDuty Integration Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: linting Signed-off-by: Ravi Hari <ravireliable@gmail.com> * docs: add documentation for pagerduty Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: update to take serviceid from annotation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * docs: update pagerduty documentation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * docs: update pagerduty documentation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: update comments Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: remove dependency Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: build/lint is broken due to dependencies changes (#85) Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: allow list of triggers in notification annotation (#65) * feat: allow list of triggers in notification annotation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: add deliveryPolicy option for slack notifications (#56) The delivery policy controls how slack messages are sent. The available modes are `Post` (default), `PostAndUpdate`, and `Update`. Signed-off-by: Daniel Lee Harple <dlh@harple.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: update slack version to latest (#68) feat: update slack version to latest (#68) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * chore: drop reflection based slack client tests (#74) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * chore: remove github.com/dgrijalva/jwt-go for CVE-2020-26160 (#73) * cve dgrijalva/jwt-go Signed-off-by: kshamajain99 <kshamajain99@gmail.com> * fix unit tests Signed-off-by: kshamajain99 <kshamajain99@gmail.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: allow list of triggers and destinaitons in notification annotation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: address lint issues Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: address goimport issues Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: allow list of triggers in notification annotation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: add deliveryPolicy option for slack notifications (#56) The delivery policy controls how slack messages are sent. The available modes are `Post` (default), `PostAndUpdate`, and `Update`. Signed-off-by: Daniel Lee Harple <dlh@harple.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: update slack version to latest (#68) feat: update slack version to latest (#68) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * chore: drop reflection based slack client tests (#74) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * chore: remove github.com/dgrijalva/jwt-go for CVE-2020-26160 (#73) * cve dgrijalva/jwt-go Signed-off-by: kshamajain99 <kshamajain99@gmail.com> * fix unit tests Signed-off-by: kshamajain99 <kshamajain99@gmail.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com> * feat: allow list of triggers and destinaitons in notification annotation Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: rebase Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: update go.mod Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: rebase Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: rebase Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: address lint issues Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: address goimport issues Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: rebase Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: remove unwanted module Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: go sum changes Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: handle cases when triggers/destinations are not passed Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: update annotation name Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: update documentation Signed-off-by: Ravi Hari <ravireliable@gmail.com> Co-authored-by: Daniel Lee Harple <dlh@harple.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Co-authored-by: Kshama Jain <kshamajain99@gmail.com> * test: check if slack message is a post or an update (#75) Relates to #74, #70. Signed-off-by: Daniel Lee Harple <dlh@harple.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * fix: update var Signed-off-by: Ravi Hari <ravireliable@gmail.com> Co-authored-by: Daniel Lee Harple <dlh@harple.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Co-authored-by: Kshama Jain <kshamajain99@gmail.com>
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ravi Hari ravireliable@gmail.com
Had similar issue in argo-rollouts: argoproj/argo-rollouts#1958