Range Limiting and ROI Pruning for Tracking and Forecasting Challenge #148

neeharperi · 2023-04-05T18:07:22Z

PR Summary

Range Limiting and ROI Pruning for Tracking and Forecasting Challenge

Testing

In order to ensure this PR works as intended, it is:

unit tested.
other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
A well-written summary explains what was done and why it was done.
The PR is adequately tested and the testing details and links to external results are included.

wqi

Took a quick pass through the PR for standards compliance. Let me know if you have any questions!

src/av2/evaluation/detection/constants.py

src/av2/evaluation/detection/eval.py

src/av2/evaluation/detection/utils.py

src/av2/evaluation/tracking/eval.py

src/av2/evaluation/tracking/utils.py

src/av2/evaluation/detection/constants.py

src/av2/evaluation/detection/eval.py

src/av2/evaluation/detection/utils.py

src/av2/evaluation/tracking/eval.py

src/av2/evaluation/tracking/utils.py

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

Neehar Peri and others added 7 commits April 2, 2023 23:12

Distance Threshold and ROI Pruning

5fa2b67

Distance Threshold and ROI Pruning

1427ee5

Hierarchical AP

fa93ea1

Update eval.py

38398da

Fix partial lint + typing.

c412ab2

Reformat.

36f89d7

fix some linting and pytest issues

448b2c2

wqi reviewed Apr 6, 2023

View reviewed changes

Neehar Peri added 3 commits April 7, 2023 00:40

PR Changes

bd32596

Fixed Linting

a4d82f5

Black Autoformat

8cf9c37

benjaminrwilson requested changes Apr 7, 2023

View reviewed changes

neeharperi and others added 18 commits April 8, 2023 01:13

Update src/av2/evaluation/detection/constants.py

a69acbe

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

Update src/av2/evaluation/detection/eval.py

6251fd8

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

PR Refinements

2edd244

Minor Fix

ebc1315

tidy code, fix forecasting evaluation

7f7cdb7

fix imports, return tuned metric values from tracking evaluation

1f6ebaa

fix linting

662614b

fix typing

582716a

fix ruff

74a538a

Test revert reformatting.

2cab177

Merge remote-tracking branch 'upstream/main'

7ca2e76

Undo formatting.

78623cd

Undo additional formatting.

bc7acc1

Revert a few more formatting changes.

0ecb2d5

Simplify expressions.

b89949f

Refactor eval.

bb89ddb

Fix imports.

6c8fcb0

Fix lint.

19c4346

benjaminrwilson and others added 13 commits April 11, 2023 11:55

Fix lint.

5bc2afe

Consolidate constants.

b79f420

Clean up.

fb577f6

Add unit test stubs.

99ae976

Update typing.

67c0e4f

Fix typing + fix lint in detection eval.

99649a6

Change detection args names.

d3722b5

Fix typing.

a6688b2

Fix lint.

449b681

Fix mypy.

89672e0

Reduce number of conversions.

7b0c5f0

Make lca columns a constant.

45061f8

fix group_frames bug

7d281c5

benjaminrwilson merged commit 02b1962 into argoverse:main Apr 14, 2023
11 checks passed

benjaminrwilson mentioned this pull request Apr 14, 2023

Fix forecasting evaluation to handle topK=1 #151

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Range Limiting and ROI Pruning for Tracking and Forecasting Challenge #148

Range Limiting and ROI Pruning for Tracking and Forecasting Challenge #148

neeharperi commented Apr 5, 2023

wqi left a comment

Range Limiting and ROI Pruning for Tracking and Forecasting Challenge #148

Range Limiting and ROI Pruning for Tracking and Forecasting Challenge #148

Conversation

neeharperi commented Apr 5, 2023

PR Summary

Testing

Compliance with Standards

wqi left a comment

Choose a reason for hiding this comment