Fix: identifiers with slashes are now permitted

arguseyes · Jan 4, 2016 · 2b3c56b · 2b3c56b
1 parent 0db3442
commit 2b3c56b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/app/action-add.js b/app/action-add.js
@@ -19,8 +19,6 @@ module.exports = function add(id) {
     var success = true;
     var shots = 0;
 
-    id = id.replace('/', '-');
-
     var baseDir = config.base + '/' + id;
     if (util.directoryExists(baseDir)) {
         rimraf.sync(baseDir);

diff --git a/app/action-compare.js b/app/action-compare.js
@@ -20,9 +20,6 @@ module.exports = function compare(id1, id2, cb) {
 
     var config = cfgLoader.getConfig();
 
-    id1 = id1.replace('/', '-');
-    id2 = id2.replace('/', '-');
-
     var diffDirectory = config.base + '/diff_' + id1 + '_' + id2;
     var dir1 = glob.sync(config.base + '/' + id1 + '/**/*.png');
     var dir2 = glob.sync(config.base + '/' + id2 + '/**/*.png');

diff --git a/app/configLoader.js b/app/configLoader.js
@@ -155,11 +155,14 @@ function _parseCliPositionalArguments(argv) {
 
     // `argus-eyes add develop`
     if (posArgs.length === 2 && posArgs[0] === 'add') {
+        posArgs[1] = posArgs[1].replace('/', '-');
         return ['add', posArgs[1]];
     }
 
     // `argus-eyes compare develop current`
     if (posArgs.length === 3 && posArgs[0] === 'compare') {
+        posArgs[1] = posArgs[1].replace('/', '-');
+        posArgs[2] = posArgs[2].replace('/', '-');
         if (posArgs[1] === posArgs[2]) {
             throw new Error('You cannot compare a set with itself');
         }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "argus-eyes",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "A cli tool for taking and comparing screenshots, useful for visual regression testing",
   "main": "bin/argus-eyes.js",
   "bin": {