Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extras buttons.min.css #154

Merged
merged 11 commits into from
Jan 27, 2022
Merged

Extras buttons.min.css #154

merged 11 commits into from
Jan 27, 2022

Conversation

argyleink
Copy link
Owner

@argyleink argyleink commented Jan 21, 2022

fixes #152

  • icons
  • custom accents
  • custom size
  • adaptive (light/dark)
  • reduced motion
  • supports inputs and buttons, also helps unmarked buttons look like submit buttons
  • file input button matches
  • docs

play around with the plain css prototype here

@argyleink argyleink self-assigned this Jan 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 21, 2022

Visit the preview URL for this PR (updated for commit 65fc673):

https://open-props--pr154-buttons-x5db5f1l.web.app

(expires Thu, 03 Feb 2022 03:13:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@argyleink
Copy link
Owner Author

add --_size as another top level customization lever

@argyleink
Copy link
Owner Author

move normalize.css button styles into this file

@argyleink
Copy link
Owner Author

argyleink commented Jan 21, 2022

gonna need docs or some docs built into a demo codepen, so stuff like below doesnt need discovered.

filled indigo customized OP button:

.btn-solid {
  --_bg: var(--indigo-6);
  --_border: var(--indigo-5);
  --_text: var(--indigo-0);
  --_ink-shadow: 0 1px 0 var(--indigo-8);
}

@argyleink
Copy link
Owner Author

argyleink commented Jan 22, 2022

2 small firefox issues:

  • icon stroke color
  • accent and link color comment value

@davideast davideast marked this pull request as ready for review January 22, 2022 20:17
@davideast davideast marked this pull request as draft January 22, 2022 20:18
@davideast
Copy link
Collaborator

Amazing.

I think the key thing here will be explaining that:

  • Including this extra will bring a very low specificity (by using where)
  • You can easily customize it with other props

I started a really simple docs example to showcase some of these thoughts.

https://open-props--button-docs-a6hwptl6.web.app/#buttons

@argyleink
Copy link
Owner Author

Screen Shot 2022-01-22 at 9 44 25 PM

seein that def gets me pumped! i bet we could easily build a little experience too that changes the accent color, size and text colors. spit out the tiny bits of mod props needed, they can copy and paste them in their css for some branded looks 🙂

i think we need an Extra section in the bottom nav instead of Buttons tho:

In extra we can document normalize props and the buttons. v1 def doesnt need to be interactive. my idea up until now was to make a normalize codepen and a buttons codepen, and kinda docublog them there. i really like the idea of an Extras section tho, really going to help clear things up. makes this related to #89 👍🏻

@argyleink argyleink marked this pull request as ready for review January 27, 2022 03:09
@argyleink argyleink merged commit 0c39374 into main Jan 27, 2022
@argyleink argyleink deleted the buttons branch January 27, 2022 03:11
@argyleink
Copy link
Owner Author

docs to come in a separate PR, this is ready for early access

kelvindecosta pushed a commit to kelvindecosta/open-props that referenced this pull request Nov 16, 2022
* v0.4 ported

* fixes multi-line

* moves normalize styles

* adds size as a single lever to customize

* file upload button support

* proper cursor for file input

* fixes firefox not allowing comments as values breaking the styling system

* fixes firefox svg path not colorized

* fileinput space matches inline padding

* cut release, for eap buttons.min.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize should bring decent buttons
2 participants