-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Portal
warning on Next.js
#802
base: reakit
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b628579:
|
Deploy preview for reakit ready! Built with commit b628579 |
Size Change: -15 B (0%) Total Size: 256 kB
ℹ️ View Unchanged
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is there anything we can do to help this one go through? 👀 |
@diegohaz any progress on this or any workaround? |
@marcospassos I paused the work on this PR to focus on v2, which has a more robust fix for this issue. In the meantime, you can install the version created for this PR ( I don't remember the error on the CI, but that's probably the only thing blocking this PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello! is there any timeline for this to be merged in the near future? I've tried this:
and it wouldn't work. I might be able to give some help 😃 Edit: it does work! repro in codesandbox here What's left on this PR? would be great if it could be merged on |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #656
Work in progress
How to test?
TBD
Does this PR introduce breaking changes?
No