Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Unix cp-style input/output arguments processing #4

Merged
merged 1 commit into from
Jul 12, 2012
Merged

More Unix cp-style input/output arguments processing #4

merged 1 commit into from
Jul 12, 2012

Conversation

afelix
Copy link
Contributor

@afelix afelix commented Jul 12, 2012

The problem was in usages like bin/coverjs --recursive --output covered mytest/*. The result of this call was ../covered/mytest/.., which is wrong (or, better to say, not very common) — cp will copy the content of the folder, not the folder itself. So this patch is the fix of such cases.

arian added a commit that referenced this pull request Jul 12, 2012
More Unix cp-style input/output arguments processing
@arian arian merged commit 0ca78e1 into arian:master Jul 12, 2012
@arian
Copy link
Owner

arian commented Jul 12, 2012

Agreed, thanks a lot!

@afelix
Copy link
Contributor Author

afelix commented Jul 18, 2012

Arian, is it possible to publish new version? We are using CoverJS in open source development and it is not very good to have personal forks in package.json.

@arian
Copy link
Owner

arian commented Jul 18, 2012

done!

On Wed, Jul 18, 2012 at 2:20 PM, Sergey Kryzhanovsky <
reply@reply.github.com

wrote:

Arian, is it possible to publish new version? We are using CoverJS in open
source development and it is not very good to have personal forks in
package.json.


Reply to this email directly or view it on GitHub:
#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants