fix: adjust max-lines

arianrhodsandlot · May 31, 2024 · fec2da3 · fec2da3
1 parent 1ffa6d1
commit fec2da3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/flat-configs/custom/custom-rules/eslint.ts b/src/flat-configs/custom/custom-rules/eslint.ts
@@ -13,13 +13,13 @@ export const eslintRules: FlatConfigRules = {
   eqeqeq: ['error', 'always', { null: 'ignore' }],
   'func-style': ['error', 'declaration'],
   'max-depth': ['error', 4],
-  'max-lines': ['error', { max: 1000, skipBlankLines: true, skipComments: true }],
-  'max-lines-per-function': ['error', { max: 500, skipBlankLines: true, skipComments: true }],
+  'max-lines': ['error', { max: 500, skipBlankLines: true, skipComments: true }],
+  'max-lines-per-function': ['error', { max: 80, skipBlankLines: true, skipComments: true }],
   'max-params': 'error',
   'new-cap': ['error', { capIsNew: false, newIsCap: true, properties: true }],
   'no-array-constructor': 'error',
   'no-caller': 'error',
-  'no-console': [isProduction ? 'error' : 'warn', { allow: ['info', 'table', 'assert', 'warn', 'error', 'trace'] }],
+  'no-console': [isProduction ? 'warn' : 'error', { allow: ['info', 'table', 'assert', 'warn', 'error', 'trace'] }],
   'no-constant-condition': ['error', { checkLoops: false }],
   'no-debugger': isProduction ? 'error' : 'warn',
   'no-dupe-class-members': 'off',

diff --git a/src/flat-configs/custom/react.ts b/src/flat-configs/custom/react.ts
@@ -1,3 +1,4 @@
+import { jsxOrTsxGlob } from '../../lib/constants.js'
 import { getContext, isPackageInstalled } from '../../lib/utils.js'
 import type { FlatConfigs } from '../../types/eslint.js'
 
@@ -26,8 +27,10 @@ export function getReactConfigs() {
 
   if (options.react) {
     reactConfigs.push({
+      files: [jsxOrTsxGlob],
       name: 'react',
       rules: {
+        'max-lines-per-function': ['error', { max: 500, skipBlankLines: true, skipComments: true }],
         'react-refresh/only-export-components': [
           'error',
           { allowConstantExport: true, allowExportNames: getAllowExportNames() },

diff --git a/src/flat-configs/recommended/base.ts b/src/flat-configs/recommended/base.ts
@@ -8,7 +8,7 @@ import type { FlatConfigs } from '../../types/eslint.js'
 export const baseConfigs: FlatConfigs = [
   {
     files: [jsOrTsGlob],
-    ignores: getGitIgnores(),
+    ignores: ['node_modules/**/*', 'dist/**/*', ...getGitIgnores()],
     languageOptions: {
       globals: {
         ...globals.browser,