Add SQLite backend to example server #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a toy example database where we can store users and associated credentials, as an example for the server, don't use this in production.
This way we still have access to the display name and username.
Merged
|
This is probably going to conflict a lot with #14 because I touched a ton of stuff in there. You shouldn't have to rebase this, as I'm the one causing trouble here. I'll rebase for you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As programmed together at ZuriHac)
This adds a simple SQLite database that stores users, and attested credential data for users. This database replaces the previous
TVar Users. There is a currently unused functiongetPublicKeyByCredentialIdthat can be used in the login-complete endpoint to get the public key to be used for verification.This is really a toy example, we don't handle things like unique constraint violations. Also, some user-provided data is inserted directly into a blob column in the database. I’m not sure if there is a size limit on those in the parser, but there is probably a DoS vector there.