Skip to content

Commit

Permalink
fix/test #1753 fixing issues in tests following #1749
Browse files Browse the repository at this point in the history
This commit fixes test issues which are happening following commit
8432f5b from #1749:
- SelectOnBlurSimpleRobotTestCase fails on Safari because a <select> in
Safari (on Mac) behaves differently than in other browsers (on Windows):
pressing the down arrow key opens the dropdown instead of only changing
the selection, as it is expected in the test
This test is now excluded from the test campaign for Safari.
- OpenDropDownFromButtonTestCase fails on IE 8 because SynEvents does not
faithfully reproduces the behavior of IE 8
This test was replaced by a robot test which correctly tests what is really
happening on IE 8
  • Loading branch information
divdavem committed Feb 3, 2017
1 parent d333ca7 commit 5d9eaef
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Aria.classDefinition({
$classpath : "test.aria.widgets.form.autocomplete.issue315.OpenDropDownFromButtonTestCase",
$extends : "aria.jsunit.TemplateTestCase",
$classpath : "test.aria.widgets.form.autocomplete.issue315.OpenDropDownFromButtonRobotTestCase",
$extends : "aria.jsunit.RobotTestCase",
$dependencies : ["aria.utils.FireDomEvent"],
$constructor : function () {
this.$TemplateTestCase.constructor.call(this);
this.$RobotTestCase.constructor.call(this);
this.setTestEnv({
template : "test.aria.widgets.form.autocomplete.issue315.OpenDropDownFromButtonTestCaseTpl",
data : {
Expand Down
6 changes: 5 additions & 1 deletion test/testConfigBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ var generalBrowserExcludes = {
"Chrome": [
"test/aria/utils/mouse/MouseDragKoRobotTestCase.js"
],
"Safari": [],
"Safari": [
// Excluded because a <select> in Safari behaves differently (pressing the down arrow key opens the
// dropdown instead of changing the selection):
"test/aria/widgets/form/select/onBlur/SelectOnBlurSimpleRobotTestCase.js"
],
"IE 7": [
"test/aria/utils/domNavigationManager/DomNavigationManagerRobotTestCase.js"
],
Expand Down

0 comments on commit 5d9eaef

Please sign in to comment.