Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1352 DatePickerWithValidatorTest IE7 failure #1352

Closed
wants to merge 2 commits into from

Conversation

jakub-g
Copy link
Collaborator

@jakub-g jakub-g commented Nov 19, 2014

This fixes a new test added in 7b13250
which was found to be failing in IE7 during release testing.

The test was failing in IE7 due to IE7 being served a different HTML
than other browsers (one more nested span in IE7). New test checks
still different HTML elements in IE7 and non-IE7 browsers, though both
of them should have an error CSS class.

@jakub-g jakub-g added this to the 1.6.8 milestone Nov 19, 2014
This fixes a new test added in 7b13250
which was found to be failing in IE7 during release testing.

The test was failing in IE7 due to IE7 being served a different HTML
than other browsers (one more nested span in IE7). New test checks
still different HTML elements in IE7 and non-IE7 browsers, though both
of them should have an error CSS class.
@divdavem
Copy link
Member

🆗 21ecdb2 is fine for me
I would prefer e5223d4 not to be integrated, as I don't understand why this .gitignore file can appear.

@jakub-g jakub-g closed this in ac37f4f Nov 20, 2014
@jakub-g jakub-g deleted the ie7-dp-validator branch November 20, 2014 09:31
@jakub-g
Copy link
Collaborator Author

jakub-g commented Nov 20, 2014

I thought gitignore was created during npm test but in fact it's created mysteriously by my eclipse when refreshing project (really weird)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants