fix #1374 utils.Dom.calculatePosition|getOffset discrepancy in webkit #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-g
added a commit
to jakub-g/ariatemplates
that referenced
this pull request
Dec 12, 2014
…ncy in webkit Due to discrepancy how browsers report page scroll (setting `scrollTop` either on `document.body` or `document.documentElement`), `aria.utils.Dom.getOffset()` returned wrong values in webkit browsers for absolutely positioned elements when the viewport was scrolled. The exact point of failure was querying explicitly `calculatePosition(document.body)` which happens when `getOffset(element)` traverses element's offsetParents up to BODY. Close ariatemplates#1375
jakub-g
added a commit
to jakub-g/ariatemplates
that referenced
this pull request
Dec 12, 2014
…ncy in webkit Due to discrepancy how browsers report page scroll (setting `scrollTop` either on `document.body` or `document.documentElement`), `aria.utils.Dom.getOffset()` returned wrong values in webkit browsers for absolutely positioned elements when the viewport was scrolled. [see https://code.google.com/p/chromium/issues/detail?id=284141] The exact point of failure was querying explicitly `calculatePosition(document.body)` which happens when `getOffset(element)` traverses element's offsetParents up to BODY. Close ariatemplates#1375
…ancy Due to discrepancy how browsers report page scroll (setting `scrollTop` either on `document.body` or `document.documentElement`), `aria.utils.Dom.getOffset()` returned wrong values in webkit browsers for absolutely positioned elements when the viewport was scrolled. [see https://code.google.com/p/chromium/issues/detail?id=284141] The exact point of failure was querying explicitly `calculatePosition(document.body)` which happens when `getOffset(element)` traverses element's offsetParents up to BODY. Close ariatemplates#1375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to discrepancy how browsers report page scroll (setting
scrollTopeither on
document.bodyordocument.documentElement),aria.utils.Dom.getOffset()returned wrong values in webkit browsersfor absolutely positioned elements when the viewport was scrolled.