fix Selectbox issue with helptext on IE 11 #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
fixSelectBoxIE11
branch
from
a67da6d
to
f090a9d
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jan 29, 2018
Fixes test.aria.widgets.form.selectbox.SelectboxTestCase on IE 11. IR 14460046 AT-1828
divdavem
force-pushed
the
fixSelectBoxIE11
branch
from
f090a9d
to
5b8ea19
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jan 29, 2018
Fixes test.aria.widgets.form.selectbox.SelectboxTestCase on IE 11. IR 14460046 AT-1828
ymeine
approved these changes
Jan 29, 2018
|
@ymeine Thank you for your review! As discussed, this change breaks |
divdavem
force-pushed
the
fixSelectBoxIE11
branch
from
5b8ea19
to
309f120
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jan 31, 2018
Fixes test.aria.widgets.form.selectbox.SelectboxTestCase on IE 11. IR 14460046 AT-1828
divdavem
force-pushed
the
fixSelectBoxIE11
branch
from
5e77a9d
to
a9a9d2c
Compare
Fixes test.aria.widgets.form.selectbox.SelectboxTestCase on IE 11. IR 14460046 AT-1828
It is now sufficient to do: npm run attester-browsers (and to connect the real browsers to the running attester with attester-launcher) Test results are saved in /test/logs/*.json
divdavem
force-pushed
the
fixSelectBoxIE11
branch
from
a9a9d2c
to
e60a498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test.aria.widgets.form.selectbox.SelectboxTestCase on IE 11.