Closes #80 - bindable width and height for Containers #215

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@vratojr
Contributor
vratojr commented Nov 6, 2012

Updated the Beans in order to take in account that "ResizableWidgetCfg" now declares bindings.
Updated dialog in order to react to resize correctly when bound.
Fixed div in order to have a proper call to container resizing method.

@vratojr
Contributor
vratojr commented Nov 6, 2012

TestApplication in: L:\Common-Temporary\AriaTemplates\testApp.7z

Simone Vratogna Closes #80 - bindable width and height for Containers
Updated the Beans in order to take in account that "ResizableWidgetCfg" now declares bindings.
Updated dialog in order to react to resize correctly when bound.
Fixed div in order to have a proper call to container resizing method.
3152607
@vratojr
Contributor
vratojr commented Nov 13, 2012

Awaiting a code review.
And maybe some automatic testing.

@jakub-g jakub-g was assigned Dec 4, 2012
@jakub-g
Collaborator
jakub-g commented Dec 13, 2012

Original issue: #80

@jakub-g
Collaborator
jakub-g commented Jan 14, 2013

This code in Container.js is problematic:

    this._sizeConstraints = (cfg.width == -1 && (!!cfg.minWidth || !!cfg.maxWidth))
            || (cfg.height == -1 && (!!cfg.minHeight || !!cfg.maxHeight));

It means that min/max width/height constraints are applied <==> width / height are equal to -1, which won't ever happen when we bind width / height to the data model. So this logic needs to be changed.

@jakub-g
Collaborator
jakub-g commented Jan 17, 2013

The issue is under development, but this pull request won't go into master as it needs to be worked on. I'll open a new pull request when I'm done.

@jakub-g jakub-g closed this Jan 17, 2013
@jakub-g
Collaborator
jakub-g commented Aug 27, 2013

The functionality landed in 1.3.5 through #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment