Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #349 maximizable Dialog service pack #383

Closed
wants to merge 1 commit into from

Conversation

jakub-g
Copy link
Collaborator

@jakub-g jakub-g commented Feb 15, 2013

Fixed issues with:

  1. Dialog maximized from start
  2. Resizing Dialog while maximized
  3. Resizing viewport while Dialog maximized
  4. Unmaximizing the Dialog after full section refresh

Additionally:

  1. Perf and readability improvements (changeProperty vs
    setProperty).
  2. Test for destroying/creating Draggable/Resizable.

@jakub-g
Copy link
Collaborator Author

jakub-g commented Feb 15, 2013

Ready for code review.

Basically what I've done is that now in maximized mode, the internal this._cfg.width|heightMaximized are used instead of this._cfg.width|height -- the original ones are untouched when maximizing, so they can survive a refresh.

Apart from that, there are small changes in the way Draggable and Resizable are handled (nullifying / creating empty container when needed) and changed the way how maximization works by implicitly calling the necessary functions instead of waiting for _onBoundPropertyChange to fire after changeProperty is called.

I've added a lot of unit tests and also tested manually on the demo site.

Fixed issues with:
1. Dialog maximized from start
2. Resizing Dialog while maximized
3. Resizing viewport while Dialog maximized
4. Unmaximizing the Dialog after full section refresh

Additionally:
1. Perf and readability improvements (`changeProperty` vs
`setProperty`).
2. Test for destroying/creating Draggable/Resizable.

Close ariatemplates#383.
@piuccio piuccio closed this in 5e7cb61 Feb 20, 2013
@piuccio
Copy link
Contributor

piuccio commented Feb 20, 2013

Integrated in 5e7cb61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants