feat #218 better stack trace in Firebug and Safari devtools #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for `Function.displayName` to have better stack traces in debugger in Firebug and Safari dev tools for the functions in `$prototype` of classes loaded via `Aria.classDefinition`. Chrome and IE9+ do not support `displayName` but they have a good built-in inferring of names of anonymous functions. IE8- do not support `displayName` nor infer the name by itself. Close ariatemplates#218. Close ariatemplates#384.
|
See #218 for preview. |
|
Great feature, will help a lot, especially knowing that stack traces can sometimes be pretty huge with AT! |
|
+1, this makes debugging much more efficient, excellent initiative Jakub! |
|
BTW I found a great article on named function expressions while investigating this (after Fabio's comments on global variables in IE). The whole article is nice, but "JScript bugs" section is insane: http://kangax.github.com/nfe/#jscript-bugs It's a bit old but most of the things there still hold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Function.displayNameto have better stacktraces in debugger in Firebug and Safari dev tools for the functions
in
$prototypeof classes loaded viaAria.classDefinition.Chrome and IE9+ do not support
displayNamebut they have a goodbuilt-in inferring of names of anonymous functions.
IE8- do not support
displayNamenor infer the name by itself.Close #218.