Refresh manager not resumed after an exception in a module controller #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a module controller
|
The pull request looks good to me, lets integrate it. |
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Sep 18, 2013
…in a module controller Close ariatemplates#735 (cherry picked from commit 74dc02a) Conflicts: test/aria/templates/TemplatesTestSuite.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another pull request to fix #727, as the previous fix only fixed half of the issue (there were several calls to
aria.templates.RefreshManager.stop()).When an exception occured in a module controller method, the interceptor (which stopped the refresh manager when the call to the module controller begins) was not called to resume the refresh manager after the exception.