Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetDateFormatW bitches, and refuses to say why. #3

Closed
ariccio opened this issue Feb 7, 2015 · 3 comments
Closed

GetDateFormatW bitches, and refuses to say why. #3

ariccio opened this issue Feb 7, 2015 · 3 comments
Assignees
@ariccio

Comments

@ariccio
Copy link
Owner

ariccio commented Feb 7, 2015

As mentioned in a followup to issue #1, GetDateFormatW can fail with "any of the parameters are invalid".

I suspect that this has something to do with the MAKELCID macro.

And yes, the Linux Kernel sources set the precedent for the use of "bitches" as a technical term.
ariccio added a commit that referenced this issue Feb 8, 2015
@ariccio
hopefully fixed issue #3
85e3ac6 
In issue #3, GetDateFormat was bitching mysteriously. Of course, the
default windows error message was useless.

So I went ahead and added a crapload of diagnostics & error reporting to
clarify what's going on.

I also refactored some arrow code, here and there.
@ariccio
Copy link
Owner Author

ariccio commented Feb 9, 2015

I'm pretty sure that I've fixed this, but I need another excuse to complain about GetDateFormatEx. It's an annoying api.

@ariccio ariccio self-assigned this Feb 9, 2015
@ariccio ariccio mentioned this issue Feb 10, 2015
Closed
@ariccio
Copy link
Owner Author

ariccio commented Mar 1, 2015

Hey, @moremachinethanman, could you see if this issue is fixed for you?

@ariccio
Copy link
Owner Author

ariccio commented Mar 24, 2015

Ok, well, for now, I'll close this issue.

@ariccio ariccio closed this as completed Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariccio ariccio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ariccio