atlasaction: enrich run ctx with actor name and id #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronenlu
commented
Feb 28, 2024
•
ronenlu
commented
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
|
Migrations automatically reviewed with Atlas |
|
Migrations automatically reviewed with Atlas |
ronenlu
commented
Feb 28, 2024
| @@ -585,12 +592,19 @@ func createRunContext(act *githubactions.Action) (*atlasexec.RunContext, error) | |||
| if branch == "" { | |||
| branch = ghContext.RefName | |||
| } | |||
| var a Actor | |||
| if err := envconfig.Process(ctx, &a); err != nil { | |||
There was a problem hiding this comment.
I have to do the parsing manually, because the GO SDK doesn't support the ACTOR_ID var:
a8m
changed the title
|
cc @giautm for review. |
giautm
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.