Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Reverse change missing comma #667

Closed
tprebs opened this issue Mar 23, 2022 · 1 comment
Closed

Postgres Reverse change missing comma #667

tprebs opened this issue Mar 23, 2022 · 1 comment

Comments

@tprebs
Copy link
Contributor

tprebs commented Mar 23, 2022

I noticed as part of using the new ent versioned migrations that all of the down scripts with column modifications were not adding commas in correctly

Up generates correctly e.g.

ALTER TABLE "subscriptions" ALTER COLUMN "created_at" SET DEFAULT CURRENT_TIMESTAMP, ALTER COLUMN "updated_at" SET DEFAULT CURRENT_TIMESTAMP;

Down has missing commas between each column change

ALTER TABLE "subscriptions" ALTER COLUMN "created_at" DROP DEFAULT ALTER COLUMN "updated_at" DROP DEFAULT;
@a8m
Copy link
Member

a8m commented Mar 24, 2022

Closed with #668

Thanks for the contribution 🙏

@a8m a8m closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants