sql/postgres: add missing comma in column changes for reverse changes in Postgres #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing comma when generating reverse changes on columns. #667
This change just adds the comma the same way it has been done for other changes and in the mysql migration but it doesn't feel right to have to manually add the comma in when generating the reverse sql when it is done automatically by
MapComma
for alter table cmd.Would it make more sense to either split the logic for reverse out into a second iteration via
reversible.MapComma
create a wrapper struct which exposes both builders to the existing code e.g.rb.MapComma(changes, func(i int, b *sqlx.Builder, rb *sqlx.Builder))
This would mean in the future the logic for applying commas is standard between the generation of the cmd and reverse