Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple HEIC support #22

Closed
Webbeh opened this issue Aug 6, 2018 · 3 comments
Closed

Apple HEIC support #22

Webbeh opened this issue Aug 6, 2018 · 3 comments

Comments

@Webbeh
Copy link

Webbeh commented Aug 6, 2018

It's no secret that Apple made that new picture format available on certain iPhones, and that there is no support, right now, for this format into Nextcloud.

Would it be possible to build this in this plugin ?

You should check "Tifig" out, here on github : https://github.com/monostream/tifig
That library is able to convert HEIC to different formats. Even if it just adds support to server owners being able to install that library/package on their system at first, it's still an improvement.

@steiny2k
Copy link
Contributor

steiny2k commented Aug 6, 2018

I think the more recent builds of ImageMagick (which this app uses to provide the previews for RAW files) support also HEIF / HEIC (see ImageMagick/ImageMagick#507). So it's not necessarily required to rely on another graphics converter such as tifig.
Based on my current understanding, this means, this app could easily be enhanced to also tackle files with the .heif extension, and call up ImageMagick to generate a preview.

Besides this I've created a PR to the main Nextcloud Server component to add HEIF / HEIC support (see nextcloud/server#10526). I'll tidy it up the next days and hope to make it into the upstream Nextcloud release.

In case Nextcloud upstream does not want to include my PR, I can adapt it to integrate it into this app, or even create a new app to release it separately.

For OwnCloud there's already a patch which is the foundation on which I've built my PR. See owncloud/core#30093

@ariselseng
Copy link
Owner

@Webbeh Lets wait for @steiny2k PR in nextcloud/server and see if it gets in.
@steiny2k I all for getting it into this app, if you cannot get it into the core.

@Webbeh
Copy link
Author

Webbeh commented Dec 27, 2018

It was merged in apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants