Close #46 #47
Merged
Close #46 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit adds a 'mode' keyword argument to the set_members method. The set_members method already looks to get the lacp_mode in use from existing members but ultimately uses 'on' if no other members exist. This commit allows you to supercede that pass in the desired lacp mode.
phil-dileo
added a commit
that referenced
this pull request
Oct 20, 2015
Add lacp mode to set_members() - Close #46
|
Release Note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_members method already looks to get the lacp_mode in use from existing
members but ultimately uses 'on' if no other members exist. This commit
allows you to supercede that pass in the desired lacp mode.