Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ospf scripts #95

Merged
merged 2 commits into from
Sep 6, 2016
Merged

Conversation

brigoldberg
Copy link
Contributor

Added OSPF to pyeapi. Created unit tests and all tests ran without error. Please feel free to critique and change if needed.

Thanks

Brian Goldberg

@phil-dileo
Copy link
Contributor

Hi Brian - you'll notice in the automated travis tests that the 'make check' command failed. This is an easy fix. You just need to add an include statement for your testing config fixture.

EG, in
https://github.com/arista-eosplus/pyeapi/blob/develop/MANIFEST.in, add

recursive-include test *.ospf

I'm still going through the code, but overall it looks great! Thank you

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage decreased (-18.1%) to 77.886% when pulling af8688f on brigoldberg:develop into 211db50 on arista-eosplus:develop.

@brigoldberg
Copy link
Contributor Author

Phillip,

It was good meeting you at the Arista Meetup on Tuesday.

I've updated my "MANIFEST.in" file and committed the change. Hopefully you
guys can merge it into the main repo.

Cheers,

Brian

On Tue, Jul 5, 2016 at 10:00 AM, Philip DiLeo notifications@github.com
wrote:

Hi Brian - you'll notice in the automated travis tests that the 'make
check' command failed. This is an easy fix. You just need to add an include
statement for your testing config fixture.

EG, in
https://github.com/arista-eosplus/pyeapi/blob/develop/MANIFEST.in, add

recursive-include test *.ospf

I'm still going through the code, but overall it looks great! Thank you


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#95 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ARhBwEa-OZRcDGMH2TMkoUCDdHjhCy8Cks5qSmNmgaJpZM4I9Ca7
.


Brian Goldberg

@phil-dileo phil-dileo merged commit e583b85 into arista-eosplus:develop Sep 6, 2016
@phil-dileo phil-dileo added this to the 0.7.0 milestone Sep 7, 2016
@phil-dileo
Copy link
Contributor

Release Notes:
This new module provides an API for OSPF configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants