feat(anta.tests): PtpGMStatus, PtpLockStatus, PtpModeStatus, PtpOffset, PtpPortModeStatus #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tpModeStatus, PtpOmfStatus, PtpPortModeStatus
|
Credits to Gerard Phillips for developing these test cases for PTP |
BarikiVarshitha
requested review from
gmuloc and
mtache
and removed request for
gmuloc
BarikiVarshitha
changed the title
mtache
requested changes
Feb 27, 2024
anta/tests/ptp2.py
Outdated
| """ | ||
| This test verifies that the device is locked to a valid GM | ||
| The user should provide a single "validGM" as an input | ||
| To test PTP failover, re-run the test with secondary GMid configured. |
There was a problem hiding this comment.
Why should we re-run the test with another input? Can we just use a list of strings as input instead?
There was a problem hiding this comment.
Do not want them to be hardcoded as they might be different for some other case, we give valid GM in the nrfu file so from there we are taking this value.
…tpModeStatus, PtpOffset, PtpPortModeStatus
BarikiVarshitha
changed the title
…tpModeStatus, PtpOffset, PtpPortModeStatus
mtache
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test cases for PTP which include: PtpGMStatus, PtpLockStatus, PtpModeStatus, PtpOmfStatus, PtpPortModeStatus
Checklist:
pre-commit run)