feat(anta.tests): Optimize VerifyRoutingTableEntry by quering all routes for a vrf.

[dlobato]

Description

Reduce number of commands executed on VerifyRoutingTableEntry by querying all routes of a vrf in one go.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have run pre-commit for code linting and typing (pre-commit run)
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes (tox -e testenv)

[carl-baillargeon]

Hey David, thanks for the PR! Did you test this against a large routing table? I remember going back and forth myself when I wrote this test. If I remember correctly I ran into issues with large routing tables and I think it was more efficient sending multiple commands.

[dlobato]

Not really, that would be an interesting test. Maybe we can sync and test. Guillaume mentioned this and he proposed to have a parameter collect: [all|unique] that could control the behavior.

[carl-baillargeon]

Not really, that would be an interesting test. Maybe we can sync and test. Guillaume mentioned this and he proposed to have a parameter collect: [all|unique] that could control the behavior.

Tested this with a full routing table and ANTA is in fact crashing. I need to investigate more but when doing the same command with curl or using HTTPX outside of ANTA, it works fine. We can probably reproduce easily with other commands that generate a very large output so that's a separate issue in my opinion.

If we implement a knob to control that behavior, we open the door for users to hit that bug. @gmuloc Thoughts?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[carl-baillargeon]

Not really, that would be an interesting test. Maybe we can sync and test. Guillaume mentioned this and he proposed to have a parameter collect: [all|unique] that could control the behavior.

Tested this with a full routing table and ANTA is in fact crashing. I need to investigate more but when doing the same command with curl or using HTTPX outside of ANTA, it works fine. We can probably reproduce easily with other commands that generate a very large output so that's a separate issue in my opinion.

If we implement a knob to control that behavior, we open the door for users to hit that bug. @gmuloc Thoughts?

Update: I was able to successfuly test the full routing table with ANTA 1.0 but we should still implement a knob in the inputs [ all | unique ] to cover the use case where we need to query a single route against a full routing table.

[carl-baillargeon]

I don't see improvements with a full routing table. Makes sense since every indiviual route is unique, not hitting the cache.

Also, we are spending a lot of time waiting on the actual HTTP response since the output is super big. Let's implement the knob for maximum flexibility.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud