Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for network 3.x? #264

Closed
peti opened this issue Feb 28, 2020 · 0 comments · Fixed by #265
Closed

Support for network 3.x? #264

peti opened this issue Feb 28, 2020 · 0 comments · Fixed by #265

Comments

@peti
Copy link

peti commented Feb 28, 2020

Current versions of aws require network ==2.*, which makes it almost impossible to mix the library with recent versions of other network-oriented code. Are there any plans to update this library to support, say network-3.1.x, which has been available for quite a long time already?

peti added a commit to NixOS/cabal2nix that referenced this issue Feb 28, 2020
Unfortunately, the 'aws' library does not support recent versions of 'network'.
Since we cannot reasonably compile with network-2.x any longer, this means that
we have to disable S3 / AWS support in git-annex until [1] is fixed.

[1] aristidb/aws#264
peti added a commit to NixOS/nixpkgs that referenced this issue Feb 28, 2020
Unfortunately, we cannot compile git-annex with S3 support in an
LTS-15.x environment, because the 'aws' library hasn't updated to
version 3.x of the 'network' library [1]. I tried whether it's
possible to build git-annex with an older version of network, but
the amount of overrides we'd have to configure to accomplish that
got out of hand quickly. So I disabled aws support [2]. If you
need S3 support in git-annex, please help upstream to update
'aws' so that it builds with recent versions of 'network'.

[1] aristidb/aws#264
[2] NixOS/cabal2nix@1d0459f
peti added a commit to NixOS/nixpkgs that referenced this issue Feb 28, 2020
Unfortunately, we cannot compile git-annex with S3 support in an
LTS-15.x environment, because the 'aws' library hasn't updated to
version 3.x of the 'network' library [1]. I tried whether it's
possible to build git-annex with an older version of network, but
the amount of overrides we'd have to configure to accomplish that
got out of hand quickly. So I disabled aws support [2]. If you
need S3 support in git-annex, please help upstream to update
'aws' so that it builds with recent versions of 'network'.

[1] aristidb/aws#264
[2] NixOS/cabal2nix@1d0459f
aristidb added a commit that referenced this issue Mar 4, 2020
fixes #264

This keeps support for building with network-2 by adding a build flag.
Cabal will automatically disable the build flag if that's the only way
to satisfy the dependencies.

At some point in the future when network-2 compatability is not useful,
it would make sense to remove the build flag.
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this issue Mar 7, 2022
Unfortunately, the 'aws' library does not support recent versions of 'network'.
Since we cannot reasonably compile with network-2.x any longer, this means that
we have to disable S3 / AWS support in git-annex until [1] is fixed.

[1] aristidb/aws#264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant