Just made the minimal amount of changes to get it to work with conduit 0.4. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,22 +136,23 @@ Library | |||
| bytestring == 0.9.*, | |||
| case-insensitive >= 0.2 && < 0.5, | |||
| cereal == 0.3.*, | |||
| conduit >= 0.2 && < 0.3, | |||
| conduit >= 0.4, | |||
There was a problem hiding this comment.
There should be an upper bound here, like
conduit >= 0.4 && < 0.5,
|
Great, thanks for doing this work. I made two comments above, everything else looks good to me. What do you think, @aristidb? |
|
I haven't tested it yet, but it looks good. |
|
Alright, I can send another pull req w/ upper bounds on those. I'll bump cabal version too. |
aristidb
added a commit
that referenced
this pull request
Apr 11, 2012
Just made the minimal amount of changes to get it to work with conduit 0.4.
|
Released as 0.4.0 as per the new VERSIONING policy. (There's a file called "VERSIONING" in the repo now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested a few PutObject ops; seems to work fine.