Fix all known bugs with PutObject #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the AWS S3 response was ignored. Now we check if the response was successful or not.
These headers are treated separately by SignedQuery.
It didn't handle cases where three or more consecutive headers had to be merged.
These headers are sent with the HTTP request but are ignored when signing the request. On headers that start with "x-amz-" should be used when signing.
|
And this goes to show the importance of reviewing patches before merging them. The bugs you're fixing are from code that came in from a pull request. :-) So far, the code is looking good. |
|
OK, looking good. I will fix the remaining bug in the merge function after merging the request. |
aristidb
added a commit
that referenced
this pull request
Jan 5, 2012
Fix all known bugs with PutObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This pull request fixes:
DeleteObjectbut didn't test it. All other commands seem fine on this issue.I hope these commits are fine to be reviewed and merged. =)
Cheers!