Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling when determining the config directory #652

Merged
merged 2 commits into from Jan 3, 2024

Conversation

imwints
Copy link
Contributor

@imwints imwints commented Oct 24, 2023

More verbose error printing when a directory is e.g. not readable

Also allow the use of read only configurations with disabled logging and persistent configuration

Closes: #650

@imwints imwints changed the title Improved error handling when determining the confi directory Improved error handling when determining the config directory Oct 24, 2023
More verbose error printing when a directory is e.g. not readable

Also allow the use of read only configurations with disabled logging and
persistent configuration
@imwints
Copy link
Contributor Author

imwints commented Jan 3, 2024

@aristocratos
Requesting review 🚀

Copy link
Owner

@aristocratos aristocratos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@aristocratos aristocratos merged commit f6cab3d into aristocratos:main Jan 3, 2024
51 checks passed
@imwints imwints deleted the config-read-only branch January 7, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reading configuration file from read-only filesystem fails.
2 participants