-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved battery detection #97
Improved battery detection #97
Conversation
- new considering all power supplies (instead of path name filtering) - only consider power supplies that are currently present - only consider power supplies of type Batter or UPS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix.
@jan-guenter |
* upstream/main: added try catch block as suggested in review aristocratos#97 (comment) improved battery detection - new considering all power supplies (instead of path name filtering) - only consider power supplies that are currently present - only consider power supplies of type Batter or UPS
According to the docs it should https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet. |
@aristocratos |
@jan-guenter |
ouch... sorry 😅 |
Improvements to the battery detection:
All changes made are in accordants to the definitions of
/sys/class/power_supply
from the kernel docsThis change was made to address the battery issue part of issue #94
This issue is still draft status, since I'm still awaiting feedback by the issue reporter @bionade24 on the test build I provided.