Rasterize example improvements #11911

betelgeuse · 2014-01-20T19:03:48Z

As requested in pull request 11907 opening an issue for my improvements for the rasterize example error handling.

betelgeuse · 2014-01-20T19:06:07Z

Not a proper reference to #11907 so repeating.

Fixes ariya#11911 and ariya#11907.

ariya · 2014-01-21T05:27:58Z

Is onResourceError necessary to quit the script? What if an embedded image fails to load, does that mean we should abandon the attempt to rasterize the page alltogether?

betelgeuse · 2014-01-21T09:31:53Z

Maybe better to just have the exit status non zero then? I thought the user wouldn't expect files to be left around when the script returns error. Guess there's a use case for rendering those too.

#11911

- Add onResourceTimeout to prevent process hang forever - Output address unreachable and set exit code to 1 - Increase setTimeout from 200ms to 500ms #11911

#11911

ariya#11911

betelgeuse added a commit to betelgeuse/phantomjs that referenced this issue Jan 20, 2014

Fix rasterize example exit status on failure

b544d13

Fixes ariya#11911 and ariya#11907.

ariya pushed a commit that referenced this issue Aug 18, 2014

Fix rasterize example exit status on failure.

80e08eb

#11911

ariya closed this as completed Aug 18, 2014

ariya pushed a commit that referenced this issue Aug 18, 2014

Improve rasterize.js

5b426f2

- Add onResourceTimeout to prevent process hang forever - Output address unreachable and set exit code to 1 - Increase setTimeout from 200ms to 500ms #11911

ariya pushed a commit that referenced this issue Aug 18, 2014

Fix rasterize example exit status on failure.

a86ae19

#11911

peter23 pushed a commit to peter23/phantomjs that referenced this issue Aug 18, 2014

Fix rasterize example exit status on failure.

a6329b8

ariya#11911

peter23 pushed a commit to peter23/phantomjs that referenced this issue Aug 18, 2014

Fix rasterize example exit status on failure.

38a5a05

ariya#11911

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rasterize example improvements #11911

Rasterize example improvements #11911

betelgeuse commented Jan 20, 2014

betelgeuse commented Jan 20, 2014

ariya commented Jan 21, 2014

betelgeuse commented Jan 21, 2014

Rasterize example improvements #11911

Rasterize example improvements #11911

Comments

betelgeuse commented Jan 20, 2014

betelgeuse commented Jan 20, 2014

ariya commented Jan 21, 2014

betelgeuse commented Jan 21, 2014