Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove CoffeeScript support #12410
It will only affect PhantomJS >= 2.0.
added a commit
Jul 30, 2014
Oh sad, this was really nice, in particular because CS had a standard library and sane stdin/stdout and command-line parsing, e.g.
helpBanner = ''' PhantomJS drop-in for wkhtmltopdf and wkhtmltoimage by Aaron Stone Usage: pjhtmltoimage [options] URL filename ''' switches = [ ['-h', '--help', 'Display help'] ['-H', '--extended-help', 'Display more extensive help, detailing less common command switches'] ['-V', '--version', 'Output version information an exit'] ] optparse = require ':/coffee-script/lib/coffee-script/optparse' parser = new optparse.OptionParser switches, helpBanner fs = require 'fs' system = require 'system' options = parser.parse system.args.slice 1 address = options.arguments output = options.arguments output = '/dev/stdout' if output is '-'
@sodabrew You can still just compile the "optparse" Coffee to JS and require the external JS file instead.
shrugs Pretty doubtful anything would change our mind on dropping it when all such compilation can just be handled ahead of time before invoking the main PhantomJS runner script.
I agree that it's the right thing from a maintenance overhead perspective, I'm only lamenting that I enjoyed the feature and I will miss it.
Huge congratulations on landing Qt5 support - I am very excited for PhantomJS 2.0!
I'll add a coffeescript make file to my project now ::||