Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Remove GIF format for screen capture export (render) #12480

Closed
ariya opened this issue Aug 20, 2014 · 6 comments
Closed

Remove GIF format for screen capture export (render) #12480

ariya opened this issue Aug 20, 2014 · 6 comments
Milestone

Comments

@ariya
Copy link
Owner

ariya commented Aug 20, 2014

One notable feature of PhantomJS is its ability to take the screenshot of a web page and save it as an image (see WebPage's render function). For the upcoming version 2.0, the only support formats for the image will be JPEG and PNG.

The reason is do remove GIF support is to reduce maintenance burden. A GIF representation of a web page can be produced by converting its PNG capture. There are numerous third-party tools which can do the job better (optimized palette, minimized loss, etc).

@ariya ariya added this to the Release 2.0 milestone Aug 20, 2014
@JamesMGreene
Copy link
Collaborator

Sounds fine to me. 👍

@zackw
Copy link
Collaborator

zackw commented Aug 21, 2014

As long as GIFs in the webpage can still be rendered, +1 from me.

@ariya ariya changed the title Remove GIF format for screen capture (render) Remove GIF format for screen capture export (render) Aug 21, 2014
ariya added a commit that referenced this issue Aug 23, 2014
This is to reduce maintenance burden.  A GIF representation of a web
page can be produced by converting its PNG capture. There are numerous
third-party tools which can do the job better (optimized palette,
minimized loss, etc).

#12480
@ariya
Copy link
Owner Author

ariya commented Aug 23, 2014

Implemented in master.

@ariya ariya closed this as completed Aug 23, 2014
@apodgorny
Copy link

Why not update docs at http://phantomjs.org/api/webpage/method/render.html?

@mysterycommand
Copy link

mysterycommand commented Jul 1, 2016

👍 to @apodgorny 's comment. Please keep your docs up to date! Oh geez, I just noticed the time stamp … it's been almost 2 years since this was implemented, but searching for "phantomjs render gif" leads to (first result) the screen capture docs "Beside PNG format, PhantomJS supports JPEG, GIF, and PDF." … and (second result) the render docs "GIF support depends on the build of Qt used"!

@apodgorny
Copy link

apodgorny commented Jul 1, 2016

@mysterycommand I'vd ditched phantom a while back for reasons known to all who touched it. My favorite now is "nightmarejs w/ electron" – it makes nicer quality snapshots and documentation up to date, it is a lot more intuitive, and much fewer bugs. That day I had to celebrate. )))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants