Can't compile release 2.1.1 with debug option #14714
Comments
Sorry, could you please elaborate? What are you trying to do? |
I want to debug #14713. So I need debug version of phantom.js, but unfortunately it does not work :( |
@goganchic what do you mean by |
@vitallium I've built phantomjs with
If I start this script with phantomjs which was built without |
@goganchic ah, yes. In the old PJS you need to comment out that assert. But you also can build WebKit with asserts disabled by passing |
@vitallium thanks a lot! Can you please tell me is there some more assets which I should comment? And one more question: what does this message in the end of phantomjs output mean |
AFAIR this is the only assert.
That means destructor wasn't called for these WebCoreNodes. You can ignore it. That's fine. |
@vitallium thanks for information! And may be you know how can I build phantomjs from master branch? There is no |
@goganchic it's pretty simple:
|
@vitallium ok, thanks! |
@vitallium one more fail
Should I comment something more? |
@goganchic no (but you can comment this assert out). Debug mode means that all asserts in WebKit will be enabled. And there are a lot of asserts :-) |
@vitallium ok, how can I set ASSERT_DISABLED option? |
|
do not work :( |
@vitallium can you please tell me what should I do exactly to add debug info but disable assertions in webkit? |
such diff worked for me: diff --git a/Source/WTF/wtf/Assertions.h b/Source/WTF/wtf/Assertions.h
index b26fa36..7940004 100644
--- a/Source/WTF/wtf/Assertions.h
+++ b/Source/WTF/wtf/Assertions.h
@@ -48,7 +48,7 @@
/* Disable ASSERT* macros in release mode. */
#define ASSERTIONS_DISABLED_DEFAULT 1
#else
-#define ASSERTIONS_DISABLED_DEFAULT 0
+#define ASSERTIONS_DISABLED_DEFAULT 1
#endif
#ifndef BACKTRACE_DISABLED
diff --git a/Source/WebCore/rendering/InlineBox.cpp b/Source/WebCore/rendering/InlineBox.cpp
index 883490b..5dad2b0 100644
--- a/Source/WebCore/rendering/InlineBox.cpp
+++ b/Source/WebCore/rendering/InlineBox.cpp
@@ -49,7 +49,7 @@ struct SameSizeAsInlineBox {
#endif
};
-COMPILE_ASSERT(sizeof(InlineBox) == sizeof(SameSizeAsInlineBox), InlineBox_size_guard);
+// COMPILE_ASSERT(sizeof(InlineBox) == sizeof(SameSizeAsInlineBox), InlineBox_size_guard);
#if !ASSERT_DISABLED
static bool inInlineBoxDetach;
diff --git a/Source/WebCore/rendering/InlineBox.h b/Source/WebCore/rendering/InlineBox.h
index 2f480c8..5ef1a41 100644
--- a/Source/WebCore/rendering/InlineBox.h
+++ b/Source/WebCore/rendering/InlineBox.h
@@ -272,7 +272,7 @@ public:
// visibleLeftEdge, visibleRightEdge are in the parent's coordinate system.
virtual float placeEllipsisBox(bool ltr, float visibleLeftEdge, float visibleRightEdge, float ellipsisWidth, float &truncatedWidth, bool&);
-#if !ASSERT_DISABLED
+#if !NDEBUG
void setHasBadParent();
#endif
@@ -415,7 +415,7 @@ protected:
// For InlineFlowBox and InlineTextBox
bool extracted() const { return m_bitfields.extracted(); }
-#if !ASSERT_DISABLED
+#if !NDEBUG
private:
bool m_hasBadParent;
#endif
@@ -427,7 +427,7 @@ inline InlineBox::~InlineBox()
}
#endif
-#if !ASSERT_DISABLED
+#if !NDEBUG
inline void InlineBox::setHasBadParent()
{
m_hasBadParent = true; |
Due to our very limited maintenance capacity, we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed (see #15395 for more details). In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution! |
Centos 7 x86_64
If i compile phantomjs without
-d
- everything works.The text was updated successfully, but these errors were encountered: