This repository has been archived by the owner on May 30, 2023. It is now read-only.
Fix Clang compilation #11611
Closed
Fix Clang compilation #11611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't test this as I don't currently have a Mac but I just wanted to stop and say "thank you" for submitting this PR and bringing this to our attention. Sorry we're being so slow to respond right now (it's the usual "overwhelmingly busy lives" story). |
|
That's ok. Given it's already upstream in Qt and Mac-only you could pretty much merge as-is? Thanks for the great project regardless 👍 |
ariya
pushed a commit
that referenced
this pull request
Oct 1, 2013
Already merged in Qt: https://qt.gitorious.org/qt/qt/commit/b82b8bfa811adcf11cb8d07d662fd2b9642deebc Issue #11611 #11611
|
Landed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already merged in Qt: https://qt.gitorious.org/qt/qt/commit/b82b8bfa811adcf11cb8d07d662fd2b9642deebc
As of OSX 10.9 Clang will be the only compiler installed by default by Xcode or the CLT so we'll need this.