This repository has been archived by the owner on May 30, 2023. It is now read-only.
[WIP] Add callbacks and feature to download files #14225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is re-implementation of my old branch of the feature to download files.
Per discussion: https://groups.google.com/d/topic/phantomjs/JChUakj--24/discussion
This pull request adds 3 new callbacks to a
WebPage
object:onFileDownload
,onFileDownloadError
andonDownloadFinished
.onFileDownload:
You can return a string with a file name, directory (in this case filename will be taken from HTTP headers), or an empty string (this will interrupt downloading).
Arguments:
filename
,size
(file size) andcontentType
.onFileDownloadError:
Arguments:
onDownloadFinished:
This is a simple callback to notify the user about finished download.
TODO:
downloadFiles
to the user.Don't merge without tests.
Issue: #10052