Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty #1 for Homayoun #22

Closed
3 tasks
kirillt opened this issue Oct 22, 2022 · 5 comments
Closed
3 tasks

Bounty #1 for Homayoun #22

kirillt opened this issue Oct 22, 2022 · 5 comments
Labels

Comments

@kirillt
Copy link
Member

kirillt commented Oct 22, 2022

We need to solve several issues at once:

  1. Migrate ResourceId from crc32 to (crc32, filesize) #20
    Ensure that everywhere ResourceID is taken from arklib, right now it is CRC32 checksum + filesize.
    When we need to print a string with both values, we can just delimit them using dash (-).

    • Update ARK-Shelf
    • Update ARK-Shelf-Desktop
    • Update ARK-Navigator
      We should also implement migration in ARK Navigator, i.e. check some value (or index version) in app data and if there is none (or version is too low) then perform storages upgrade. Index and previews could be just dropped. Storages must be backed up before performing upgrade and old resource ids must be replaced by new resource ids. E.g. 5839051: english, greek must be replaced with 88363-5839051: english, greek in .ark/tags, etc.
  2. Provide Android API for indexes and storages #21
    Basically, we just need to take code from Navigator and move it into arklib-android, ensuring any app could just import couple of modules and use metadata as well as index. We don't really need indexing in the apps right now (except Navigator). Could be useful later.

  3. Separate user-defined properties into dedicated storage ARK-Memo#8
    We need to use new metadata storage and separate title into it. Also, we can introduce created-date metadata field.
    This issue is kinda similar to Handling Link-to-Web resources using ArkLib ARK-Shelf#21

@kirillt
Copy link
Member Author

kirillt commented Oct 25, 2022

Just noticed that Navigator writes empty metadata storages to disk:

[kirill@lenovo ~]$ for f in Pictures/.ark/meta/* ; do cat $f ; echo ; done
null
null
null
null
null
null

I think, we should not write empty storages. Not all resource kinds use metadata storage at all, so better to keep disk clean.

@HLABZcc
Copy link

HLABZcc commented Oct 28, 2022

Interested! 😎

@kirillt
Copy link
Member Author

kirillt commented Nov 23, 2022

@hhio618 btw I haven't seen you applied for the bounty itself..
https://gitcoin.co/issue/29473

@ginanisque
Copy link

Hi. I would like to know if this bounty is still available?

@kirillt
Copy link
Member Author

kirillt commented Jan 13, 2023

This set of tasks was split into smaller bounties.

@kirillt kirillt closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants