Make change of async payment spendable #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent spending penidng vtxos to app level
louisinger
approved these changes
Sep 19, 2024
Co-authored-by: Louis Singer <louisinger@users.noreply.github.com> Co-authored-by: João Bordalo <bordalix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, once an async payment is completed, the ASP registers the change (if existing) as a non-pending vtxo so that it can be spent without being claimed.
As the sent vtxo now contains a revert policy, the asp returns it as spendable when the sender calls ListVtxos. Since we don't implement any revert feature, changes have been introduced to the SDK to ignore such vtxos.
NOTE: contains minor fixes to common and server's interface layer.
Closes #292.
Please @louisinger @sekulicd @bordalix review this.