[code-generator] 自動生成コードの @note に，生成元DBのコミットハッシュと生成パラメータを出力する #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@ToshiAki64 @hender14 |
meltingrabbit
changed the title
meltingrabbit
commented
Dec 14, 2023
ToshiAki64
reviewed
Dec 14, 2023
Comment on lines
12
to
14
| * path_to_db: ../examples/subobc/tlm-cmd-db/ | ||
| * max_tlm_num: 256 | ||
| * driver_path: aocs/ |
There was a problem hiding this comment.
path_to_dbやdriver_pathって、各自で別のpathになる可能性があり、各衛星ブランチで共通のドライバをdevelopからマージする際にドライバを生成した人の環境によって、変わってしまうのではないかと思ったのですが？
There was a problem hiding this comment.
たしかにそうですね．
消す場合，sub obcの場合は，どのリポジトリか？の情報が残せないのがつらいですね．少し考えます
There was a problem hiding this comment.
リポジトリ名と，
自身のDBの場合は，DBの全csvのダイジェスト，
sub obcについてはそのコミットハッシュを残すようにしました．
hender14
reviewed
Dec 15, 2023
examples/mobc/src/src_user/component_driver/aocs/aobc_command_definitions.h
Outdated
Show resolved
Hide resolved
examples/subobc/src/src_user/tlm_cmd/block_command_definitions.h
Outdated
Show resolved
Hide resolved
meltingrabbit
force-pushed
the
feature/add_metadata_for_generator
branch
from
6ba4ef7
to
9105700
Compare
meltingrabbit
commented
Dec 15, 2023
|
@hender14 @ToshiAki64 レビューお願いします |
1 task
ToshiAki64
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
自動生成コードの @note に，生成元DBのコミットハッシュと生成パラメータを出力する．
これによって，生成されたコードから，元のDBや生成パラメータがわかるようになる
自身のdbから生成されたコードには，そのdbに含まれるすべてのcsvのmd5を結合したものをさらにmd5にしたもの，
sub obcのdbについては，そのコミットハッシュを記録している．
Issue
NA
検証結果
CIが通ればOK
影響範囲