Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-generator] Refactor code-generator #251

Merged
merged 17 commits into from
Dec 25, 2023
Merged

[code-generator] Refactor code-generator #251

merged 17 commits into from
Dec 25, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Dec 19, 2023

概要

#240 で追加された挙動の修正・warning の追加など

Issue

  • 関連する issue

詳細

  • git コマンドを叩く際,エラーメッセージを生成コードに含めるべきではない
  • commit hash が取得できなかった時には曖昧にゼロ埋めすべきでない(この生成コードを機械的に処理するわけではないし,fallback 出力であることを明示すべき)
  • git remote は github.com だけではない
  • MD5 の計算における改行コードの統一は CRLF ではなく LF にしたい(Linux 文化圏に寄せるため)
    • 「ファイル一覧をソートして各ファイルの MD5 の一覧の MD5 を取ったもの」と言って空で書けるシェルスクリプトと同じ出力にしたい
  • code generation check CI での subobc のスキップが雑すぎる上に分かりにくい
    • 一旦は sed でやっていたことを jq でやるように

検証結果

test へのリンクや,検証結果へのリンク

影響範囲

c2a-code-generator

@sksat sksat added priority::high priorityg high tools labels Dec 19, 2023
@sksat sksat self-assigned this Dec 19, 2023
code-generator/my_mod/util.py Outdated Show resolved Hide resolved
code-generator/my_mod/util.py Outdated Show resolved Hide resolved
@sksat sksat force-pushed the hotfix/code-generator branch 2 times, most recently from 4a57dba to 4a89161 Compare December 20, 2023 02:36
@sksat sksat force-pushed the hotfix/code-generator branch 2 times, most recently from f44fe2b to 57aede0 Compare December 20, 2023 02:42
@sksat sksat merged commit d2b69e1 into main Dec 25, 2023
38 checks passed
@sksat sksat deleted the hotfix/code-generator branch December 25, 2023 06:59
@meltingrabbit meltingrabbit changed the title Refactor code-generator [code-generator] Refactor code-generator Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants