Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release binary suffix to wildcard for target triple #102

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 12, 2024

概要

#97 でビルド済みバイナリの処理にバグがあったので修正

変更の意図や背景

release workflow でビルドしているバイナリは suffix として target triple を付けているが,chmod や GitHub Releases へのファイル添付処理などでそれを加味するのを忘れていた

発端となる Issue

@sksat sksat added the bug Something isn't working label Mar 12, 2024
@sksat sksat self-assigned this Mar 12, 2024
@sksat sksat requested a review from KOBA789 as a code owner March 12, 2024 14:29
@KOBA789 KOBA789 merged commit 62ff2e9 into main Mar 12, 2024
4 checks passed
@KOBA789 KOBA789 deleted the fix-release-binary-suffix branch March 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants