Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #121 from ghacksuserjs/Standardize-Part1
Standardize Part1 #115
- Loading branch information
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits:
0903+0904: replace Mozilla with Firefox ?
Those are weird sentences now:
1272: enable advanced display information on Insecure Connection warning pages
2708: disable HTTP sites from setting cookies with the "secure" directive
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will check those nits - am working on part 2 now.
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. sorry for late reply. Didn't see the pull request because I haven't logged in for a while.
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries
displayinformation on Insecure Connection warning pagesfromsetting cookies with the "secure" directiveAbove changes in upcoming Standardize Part2 which I will do as a PR
PS: Was worried u were nabbed by an acronym and water boarded by oompa loompas
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the old version for 1272 because it described it the best. It's not about enable/disable but displaying the information by default without needing to click on the button first. We should aim to describe the result of a pref as good as possible instead of going way overboard with trying to always use enable/disable.
Lol, no, I'm still here. If they find me with 2 gunshot wounds to the back of the head, don't believe their lies - it wasn't suicide :)
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can allow "display" as a key word to start with - I have some others that fit this. Will reverse 1272
b8a6f2aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crap ... I liked Jeremy Renner .. wonder who will replace him in the Avengers