-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo: standardize descriptions [within reason] #115
Labels
Comments
You use similar terms as 'stop' in place of 'disable' and I see zero problems with it.
/* 0208 That's a proper enforcing action, so no change IMHO
/* 3022: 'hide' is good to me. I personally like your ways of describing in the file, seems like a spoken discourse and fits well in the file description. |
Thorin-Oakenpants
added a commit
that referenced
this issue
May 17, 2017
Thorin-Oakenpants
added a commit
that referenced
this issue
May 21, 2017
Thorin-Oakenpants
added a commit
that referenced
this issue
May 23, 2017
Thorin-Oakenpants
added a commit
that referenced
this issue
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
suggestion - go thru the entire js and streamline how we describe prefs - key word is the first word
We current have enable, disable, set, enforce, use, stop (see 0607), limit, force (see 0907 - could easily be enable) etc etc... disable/enable/set are perfect. Suggest we change as many of the others as possible to use either a standardized set of words where possible. I haven't gone thru the entire js yet.
-update-
OK, so I have 110 numbered items NOT starting with
enable
ordisable
orset
. Exclude the 7 from 2697* about navigator objects, and exclude the 10 from 2698* about isolating. That leaves 93. I haven't actually read the list in full, just dumping it here.The text was updated successfully, but these errors were encountered: