Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: standardize descriptions [within reason] #115

Closed
Thorin-Oakenpants opened this issue May 13, 2017 · 1 comment
Closed

ToDo: standardize descriptions [within reason] #115

Thorin-Oakenpants opened this issue May 13, 2017 · 1 comment
Assignees

Comments

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented May 13, 2017

suggestion - go thru the entire js and streamline how we describe prefs - key word is the first word

We current have enable, disable, set, enforce, use, stop (see 0607), limit, force (see 0907 - could easily be enable) etc etc... disable/enable/set are perfect. Suggest we change as many of the others as possible to use either a standardized set of words where possible. I haven't gone thru the entire js yet.

-update-
OK, so I have 110 numbered items NOT starting with enable or disable or set. Exclude the 7 from 2697* about navigator objects, and exclude the 10 from 2698* about isolating. That leaves 93. I haven't actually read the list in full, just dumping it here.

see PR Standardize Part1 & Part2
@Atavic
Copy link

Atavic commented May 14, 2017

You use similar terms as 'stop' in place of 'disable' and I see zero problems with it.

change wording to "set"?

/* 0208 That's a proper enforcing action, so no change IMHO

change wording to "disable"?

/* 3022: 'hide' is good to me.

I personally like your ways of describing in the file, seems like a spoken discourse and fits well in the file description.

@Thorin-Oakenpants Thorin-Oakenpants self-assigned this May 15, 2017
Thorin-Oakenpants added a commit that referenced this issue May 17, 2017
Thorin-Oakenpants added a commit that referenced this issue May 20, 2017
Thorin-Oakenpants added a commit that referenced this issue May 21, 2017
Thorin-Oakenpants added a commit that referenced this issue May 23, 2017
@Thorin-Oakenpants Thorin-Oakenpants changed the title clean up use of description actions ToDo: standardize descriptions [within reason] May 23, 2017
Thorin-Oakenpants added a commit that referenced this issue May 24, 2017
Thorin-Oakenpants added a commit that referenced this issue May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants